From 4a08c0fda59982b2641eb3b4e9b9f644cc24d1b1 Mon Sep 17 00:00:00 2001 From: Evan Jones Date: Fri, 6 Dec 2024 13:23:47 -0500 Subject: [PATCH] rocksdb/db.h: GetDbIdentity comment: ID comes from MANIFEST Commit 98c33cb8e3 changed the default for the write_dbid_to_manifest option, so this ID now comes from MANIFEST and not IDENTITY. Update the comment to reflect that. Remove 2 unneeded words from the comment on GetDbSessionId since it refers to this function. --- include/rocksdb/db.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/rocksdb/db.h b/include/rocksdb/db.h index 9beb4e74f6d..5f58d293fff 100644 --- a/include/rocksdb/db.h +++ b/include/rocksdb/db.h @@ -1989,15 +1989,15 @@ class DB { virtual Status VerifyChecksum() { return VerifyChecksum(ReadOptions()); } - // Returns the unique ID which is read from IDENTITY file during the opening - // of database by setting in the identity variable - // Returns Status::OK if identity could be set properly + // Copies the database's unique ID into identity. The ID is read from the + // MANIFEST file when opening the database. See the write_dbid_to_manifest + // option for details. Returns Status::OK if identity was set. virtual Status GetDbIdentity(std::string& identity) const = 0; // Return a unique identifier for each DB object that is opened // This DB session ID should be unique among all open DB instances on all // hosts, and should be unique among re-openings of the same or other DBs. - // (Two open DBs have the same identity from other function GetDbIdentity when + // (Two open DBs have the same identity from GetDbIdentity when // one is physically copied from the other.) virtual Status GetDbSessionId(std::string& session_id) const = 0;