Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure with Python 3.13 #2358

Open
bendk opened this issue Dec 28, 2024 · 8 comments
Open

Build failure with Python 3.13 #2358

bendk opened this issue Dec 28, 2024 · 8 comments

Comments

@bendk
Copy link

bendk commented Dec 28, 2024

The Python code uses _Py_IsFinalizing, but that's been renamed to Py_IsFinalizing in Python 3.13. Here's an Apache Arrow issue and PR that explains the problem and how to fix it.

@Ko496-glitch
Copy link

@bendk can i take this issue ?

@bendk
Copy link
Author

bendk commented Jan 8, 2025

Sure, please do.

@Ko496-glitch
Copy link

@bendk Correct if i am wrong but from what i understand when the PR was created and looking up the background info i am given to understand that i should take these steps to track the issue.

  1. Check the version gated #define for Py_IsFinalizing.
  2. Check if the pythoncapi-compat is breaking anything for transition _Py_isFinalizing -> Py_IsFinalizing
    If you can provide more info on this it would be really helpful
    Thanks

@bendk
Copy link
Author

bendk commented Jan 8, 2025

I think you can do the same steps as the PR:

  • Change _Py_isFinalizing to Py_IsFinalizing
  • Add a #define with a version check that defines Py_IsFinalizing for older python versions.

@Ko496-glitch
Copy link

Oka i will start from header files.

@Ko496-glitch
Copy link

opening a PR

@Ko496-glitch
Copy link

@bendk PR submitted please let me know if there are any other changes too i have to make.
Thanks!

@bendk
Copy link
Author

bendk commented Jan 9, 2025

Great! It looks good to me, but I'm just a user of the library. I don't have the power to approve the PR. Hopefully someone from facebook will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants