-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would it be possible to add types for typescript? #64
Comments
Hey @joshpetit, I am not personally planning to start using TypeScript, but if you are willing to contribute a PR I would be glad to review and integrate/publish. Is it these types your are thinking off? Out of curiosity - what's your project? |
Yess indeed those types. I'll look into generating types in that case then. My project is being able to use this package in conjunction with a neovim Bible study tool. I've already made a POC that I use daily that has made my Bible study so much better and enjoyable haha. I want to expand it so I am trying to set up the project in a way that makes it easier to maintain and add new features (types, documentation, all that jazz) |
I'm thinking of trying out this project for my new VS Code extension (basically in proof of concept stage), and am also using typescript. https://github.com/timbze/vscode-bible-passage-retriever Using Cursor app I created this branch for creating types... though I am not sure how close to working it is, have not tested at all. https://github.com/timbze/node-sword-interface/tree/typscript_types. Just thought I'd send this info in case someone wants to use it before me :) |
@joshpetit @timbze |
@tobias-klein My extension works satisfactorily for myself so I don't have plans to continue with this for now. Would enjoy but not enough time. |
Hey, thank you for building this awesome package.
I've been using it in a project I've been developing and I would appreciate if there could be some typescript types that are shipped along with the package to npm.
I plan on using this package so if you don't find time to do this I can look into it myself. Thank you!
The text was updated successfully, but these errors were encountered: