Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: Add more metrics to op-supervisor #13760

Open
tyler-smith opened this issue Jan 14, 2025 · 2 comments
Open

Interop: Add more metrics to op-supervisor #13760

tyler-smith opened this issue Jan 14, 2025 · 2 comments
Labels
H-interop Hardfork: change planned for interop upgrade

Comments

@tyler-smith
Copy link
Contributor

We have support for metrics but don't utilize them well yet. We should think of and add reasonable metrics that we can use to monitor the health and status of the supervisor.

@axelKingsley
Copy link
Contributor

Regarding metrics, that could be a good team exercise of identifying metric locations. It promotes an understanding of the service behavior. At first glance,

  • every event can support a counter metric at least, with more metrics specific to the nature of the event.
  • API calls over the wire probably already have metrics for free, which just need to be unified with events in Grafana
  • Database specific metrics? 🤔

@protolambda
Copy link
Contributor

Copy-pasting from discord for context:

The op-node has generic events-systems metrics utils which we can reuse

And I think it may be useful to just create a kind of like a status package like we have with op-node. And then just wait for all kinds of events, and use the event contents to update the metrics. That avoids having to install metrics into every individual module.

@emhane emhane added H-interop Hardfork: change planned for interop upgrade and removed A-interop labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
H-interop Hardfork: change planned for interop upgrade
Projects
None yet
Development

No branches or pull requests

4 participants