Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interop: Do dependency set check offchain #13658

Closed
tynes opened this issue Jan 9, 2025 · 1 comment
Closed

Interop: Do dependency set check offchain #13658

tynes opened this issue Jan 9, 2025 · 1 comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock

Comments

@tynes
Copy link
Contributor

tynes commented Jan 9, 2025

We have decided to move more code offchain rather than having it onchain. The new design involves putting the dependency set check and the start time check in the fork choice rule, block builder and proof rather than onchain. It is the responsibility of the block builder to not include blocks that include transactions that are invalid per these rules, otherwise the block will be reorg'd out and replaced with a deposits only block.

#13626 deletes the following code:

    function _checkIdentifier(Identifier calldata _id) internal view {
        if (_id.timestamp > block.timestamp || _id.timestamp <= interopStart()) revert InvalidTimestamp();
        if (!IDependencySet(Predeploys.L1_BLOCK_ATTRIBUTES).isInDependencySet(_id.chainId)) {
            revert InvalidChainId();
        }
    }
@protolambda
Copy link
Contributor

Smart-contract side is done.
Opened an issue to track the op-supervisor side of this: #13732

@protolambda protolambda added the A-pkg-contracts-bedrock Area: packages/contracts-bedrock label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock
Projects
Status: No status
Development

No branches or pull requests

3 participants