From 1dfcbf1c0bc621a630c770cec72d58d5523585cd Mon Sep 17 00:00:00 2001 From: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Date: Wed, 12 Jun 2024 20:01:12 +0530 Subject: [PATCH 1/5] fix: code snippet in json-api/request api docs --- packages/json-api/src/request.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/json-api/src/request.ts b/packages/json-api/src/request.ts index ce69d0151f6..b890789ab9d 100644 --- a/packages/json-api/src/request.ts +++ b/packages/json-api/src/request.ts @@ -31,8 +31,8 @@ import { findRecord } from '@ember-data/json-api/request'; const options = findRecord('ember-developer', '1', { include: ['pets', 'friends'] }); -/\* - => { +/* + { url: 'https://api.example.com/v1/ember-developers/1?include=friends,pets', method: 'GET', headers: , @@ -41,7 +41,7 @@ const options = findRecord('ember-developer', '1', { include: ['pets', 'friends' op: 'findRecord'; records: [{ type: 'ember-developer', id: '1' }] } -*\/ +*\ ``` Request builder output may be used with either `requestManager.request` or `store.request`. From f550309acea1f2365e5f18ab478d014d2ee193f4 Mon Sep 17 00:00:00 2001 From: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Date: Tue, 2 Jul 2024 00:42:52 +0530 Subject: [PATCH 2/5] fix: code snippet in json-api/request.ts documentation --- packages/active-record/src/request.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/active-record/src/request.ts b/packages/active-record/src/request.ts index 1f6c37c6b51..51d1281fbf3 100644 --- a/packages/active-record/src/request.ts +++ b/packages/active-record/src/request.ts @@ -31,7 +31,7 @@ import { findRecord } from '@ember-data/active-record/request'; const options = findRecord('ember-developer', '1', { include: ['pets', 'friends'] }); -/\* +/* => { url: 'https://api.example.com/v1/ember_developers/1?include=friends,pets', method: 'GET', @@ -39,7 +39,7 @@ const options = findRecord('ember-developer', '1', { include: ['pets', 'friends' op: 'findRecord'; records: [{ type: 'ember-developer', id: '1' }] } -*\/ +*\ ``` Request builder output may be used with either `requestManager.request` or `store.request`. From 5fc6d35607b2a88471963008af305f927342181f Mon Sep 17 00:00:00 2001 From: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Date: Tue, 2 Jul 2024 01:31:03 +0530 Subject: [PATCH 3/5] Update packages/json-api/src/request.ts Co-authored-by: Chris Thoburn --- packages/json-api/src/request.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/json-api/src/request.ts b/packages/json-api/src/request.ts index b890789ab9d..e46139460c6 100644 --- a/packages/json-api/src/request.ts +++ b/packages/json-api/src/request.ts @@ -41,7 +41,7 @@ const options = findRecord('ember-developer', '1', { include: ['pets', 'friends' op: 'findRecord'; records: [{ type: 'ember-developer', id: '1' }] } -*\ +* / ``` Request builder output may be used with either `requestManager.request` or `store.request`. From c8f0254b75bcb5b353ec8d4aa011ec900b280a7f Mon Sep 17 00:00:00 2001 From: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Date: Tue, 2 Jul 2024 01:31:32 +0530 Subject: [PATCH 4/5] Update packages/active-record/src/request.ts Co-authored-by: Chris Thoburn --- packages/active-record/src/request.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/active-record/src/request.ts b/packages/active-record/src/request.ts index 51d1281fbf3..e1b65859c9e 100644 --- a/packages/active-record/src/request.ts +++ b/packages/active-record/src/request.ts @@ -39,7 +39,7 @@ const options = findRecord('ember-developer', '1', { include: ['pets', 'friends' op: 'findRecord'; records: [{ type: 'ember-developer', id: '1' }] } -*\ +* / ``` Request builder output may be used with either `requestManager.request` or `store.request`. From 25b78be74dee32567ac561758548c3858c832a2b Mon Sep 17 00:00:00 2001 From: Mehul Kiran Chaudhari <55375534+MehulKChaudhari@users.noreply.github.com> Date: Tue, 2 Jul 2024 01:36:51 +0530 Subject: [PATCH 5/5] fix: comment --- packages/json-api/src/request.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/json-api/src/request.ts b/packages/json-api/src/request.ts index 5fd011410e8..e46139460c6 100644 --- a/packages/json-api/src/request.ts +++ b/packages/json-api/src/request.ts @@ -41,7 +41,7 @@ const options = findRecord('ember-developer', '1', { include: ['pets', 'friends' op: 'findRecord'; records: [{ type: 'ember-developer', id: '1' }] } -*/ +* / ``` Request builder output may be used with either `requestManager.request` or `store.request`.