Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security): use SFTP instead of FTP #175

Closed
JaeAeich opened this issue May 21, 2024 · 3 comments
Closed

feat(security): use SFTP instead of FTP #175

JaeAeich opened this issue May 21, 2024 · 3 comments
Labels

Comments

@JaeAeich
Copy link

Description:
Currently on main branch we are ignore a bandit error which is caused due due to use of FPT modules and its related functions. To keep data transfer secure and encrypted it would be recommended to use SFTP than FTP.

@uniqueg
Copy link
Member

uniqueg commented May 21, 2024

As mentioned earlier, we may still need to continue supporting FTP. But before anything about any of that, we probably need to think about designing a sytem for truly pluggable support of different filers. I guess that should already go a long way. Still might not fix that Bandit error (if we decide to keep regular FTP, we probably need to bite that bullet), but at least it would make the code base saner/more maintainable and also make it easier to drop support for a given filer.

@JaeAeich
Copy link
Author

perfectly understandable, feel free to close the issue if you'd like, I just opened it so that we have a log that such a thing was discussed or we can look back at why we ignored the bandit error.

@uniqueg
Copy link
Member

uniqueg commented May 21, 2024

Very good, thanks a lot. Attached "wontfix" and will close this now, to be revisited later.

To summarize:

  • In the mid-term, it probably makes sense to refactor the filer code (opened refactor: redesign filers #179 to discuss this)
  • Once we have a better setup for adding new filers, we can implement SFTP when somebody asks for it
  • We can discuss removing FTP at a later point (I don't it is necessarily tied to the question of whether or not we should SFTP)

@uniqueg uniqueg closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants