You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
For this we don't need to click any button. We have a webhooks_controller that receive all events from Github repository in order to trigger the benchmark jobs. This requires a few interactions, I will try to explain and show where exactly the problem is placed:
First we register a repository in our backend so its allowed to use our service
Then the repository register webhooks for pull requests and push events to be sent to our handlers
When an event occurs, our webhook handler extract the type of event (PR or push) and do some logic in order to create a job
In the process of creating a job, we try to connect to the github repository to find and download a specific file in the folder benchee/config.yml any failure on this process should be explicit. Nowadays the only failure is {:error, :bad_request} and we need to know where the error came from. Was it due to internet connection? Was it due to file not found? Or some missing configurations in the file?
To address this, we can rely on writing more tests scenarios for our webhooks_controller and responding correctly to this errors.
{:error, :bad_request} is not a clear message. Should return detailed error in config.yml... not found, malformed or something.
The text was updated successfully, but these errors were encountered: