Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give better errors when fetching config.yml for repo fails #47

Open
tallysmartins opened this issue Aug 12, 2018 · 3 comments
Open

Give better errors when fetching config.yml for repo fails #47

tallysmartins opened this issue Aug 12, 2018 · 3 comments

Comments

@tallysmartins
Copy link
Member

{:error, :bad_request} is not a clear message. Should return detailed error in config.yml... not found, malformed or something.

@denys-medynskyi
Copy link

👋 can I take this one?

@denys-medynskyi
Copy link

denys-medynskyi commented Oct 8, 2018

Can you give step by step instructions:

  • which button to click
  • what to download
  • what is expected message

@tallysmartins
Copy link
Member Author

For this we don't need to click any button. We have a webhooks_controller that receive all events from Github repository in order to trigger the benchmark jobs. This requires a few interactions, I will try to explain and show where exactly the problem is placed:

  1. First we register a repository in our backend so its allowed to use our service
  2. Then the repository register webhooks for pull requests and push events to be sent to our handlers
  3. When an event occurs, our webhook handler extract the type of event (PR or push) and do some logic in order to create a job

In the process of creating a job, we try to connect to the github repository to find and download a specific file in the folder benchee/config.yml any failure on this process should be explicit. Nowadays the only failure is {:error, :bad_request} and we need to know where the error came from. Was it due to internet connection? Was it due to file not found? Or some missing configurations in the file?

To address this, we can rely on writing more tests scenarios for our webhooks_controller and responding correctly to this errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants