Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the folder path to the vault helm values #1758

Open
marctuerke opened this issue Jan 20, 2025 · 0 comments
Open

Add the folder path to the vault helm values #1758

marctuerke opened this issue Jan 20, 2025 · 0 comments
Labels
enhancement New feature or request triage all new issues awaiting classification

Comments

@marctuerke
Copy link

marctuerke commented Jan 20, 2025

WHAT

The folder path for the vault should be added to the vault configuration. The folder path specifies the folder structure after the VAULT_SECRET_DATA_PATH.

In the EDC Dataspace Connector the folder path is added to the the secret URL, when it is not null.

if (folderPath != null) {
    builder.addPathSegments(PathUtil.trimLeadingOrEndingSlash(folderPath));
}

For example with the following specs:

  • secretPath: v1/secret
  • entryType/VAULT_SECRET_DATA_PATH: data
  • folderPath: department-1
  • key: token

the secret url should be v1/secret/data/department-1/token.

WHY

Currently, it is not possible to specify the folder path, so all edc secrets must be stored directly in the data path.

I want to specify access policies for specific vault paths and this is not possible with the current configuration. A workaround would be to add a second data path after the mandatory data path and my preferred folder structure, but this is not a good practice.

Example:

I have a sales department, which should only be able to read and update its own secrets. The secrets are stored under the path secret/data/sales, but with the current EDC configuration it is not possible to use this folder structure.

HOW

The folder path is already implemented in the Eclipse EDC with the settings key edc.vault.hashicorp.folder. It needs only to be added to the helm chart for example as the value vault.hashicorp.paths.folder and to the environment variables of the deployments of the control plane and the data plane.

@marctuerke marctuerke added enhancement New feature or request triage all new issues awaiting classification labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage all new issues awaiting classification
Projects
Status: Open
Development

No branches or pull requests

1 participant