Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update pb2nc to work with bufrlib 12.1.0 #3054

Open
22 tasks
georgemccabe opened this issue Jan 16, 2025 · 0 comments
Open
22 tasks

Enhancement: Update pb2nc to work with bufrlib 12.1.0 #3054

georgemccabe opened this issue Jan 16, 2025 · 0 comments
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: PreProcessing Tools (Point) type: enhancement Improve something that it is currently doing

Comments

@georgemccabe
Copy link
Collaborator

georgemccabe commented Jan 16, 2025

While testing the MET conda recipe for dtcenter/METplus#2863, I discovered that pb2nc crashes when using bufrlib 12.1.0, which is the version that is provided via NCEPLIBS-bufr in conda-forge. This version of bufrlib also supports the Intel OpenAPI compilers (see release notes).

The following error is output:

 ***********BUFR ARCHIVE LIBRARY ABORT**************
 BUFRLIB: PARUSR - INPUT STRING () HAS

                   NO STORE NODES

 ***********BUFR ARCHIVE LIBRARY ABORT**************

Describe the Enhancement

Update calls to bufrlib for pb2nc to prevent this error.

Time Estimate

Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as a MET-X.Y.Z version, Consider for Next Release, or Backlog of Development Ideas
  • For a MET-X.Y.Z version, select the MET-X.Y.Z Development project

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: MET-X.Y.Z Development project for development toward the next official release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.
@georgemccabe georgemccabe added alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: PreProcessing Tools (Point) type: enhancement Improve something that it is currently doing labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in MET-12.1.0 Development Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alert: NEED ACCOUNT KEY Need to assign an account key to this issue alert: NEED CYCLE ASSIGNMENT Need to assign to a release development cycle alert: NEED MORE DEFINITION Not yet actionable, additional definition required MET: PreProcessing Tools (Point) type: enhancement Improve something that it is currently doing
Projects
Status: 🩺 Needs Triage
Development

No branches or pull requests

1 participant