Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull Compilation Fixits When Building #5

Open
dsanders11 opened this issue Nov 2, 2020 · 1 comment
Open

Pull Compilation Fixits When Building #5

dsanders11 opened this issue Nov 2, 2020 · 1 comment
Labels
enhancement ✨ New feature or request

Comments

@dsanders11
Copy link
Owner

Pull any compilation errors from e build and turn them into VS Code diagnostic errors. Can get exact source range info from Clang if it runs with -fdiagnostics-print-source-range-info and can pull the quick fixes with -fdiagnostics-parseable-fixits.
@dsanders11 dsanders11 added the enhancement ✨ New feature or request label Nov 3, 2020
@dsanders11
Copy link
Owner Author

Compilation errors are currently implemented and handled with problem matchers, which is nice. Getting the fixits won't be straightforward unfortunately since plumbing in that Clang compilation flag only when using the extension is tricky. Chromium has an apply_fixits.py script, and their advice for turning on the flag is to manually edit build/config/compiler/BUILD.gn which isn't going to work for this situation.

@dsanders11 dsanders11 changed the title Pull Compilation Errors When Building Pull Compilation Fixits When Building Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement ✨ New feature or request
Projects
vscode-electron-build-tools Backlog
Status: Todo 🗒
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dsanders11