From e662e56eb32c45873b34cd88f0361d4f70838f4e Mon Sep 17 00:00:00 2001 From: Shubham Goyal Date: Fri, 29 Nov 2024 15:42:00 +0530 Subject: [PATCH] Remove misleading comment There is no 1 MB limitaion on data we can can query in sql queries, the only limitaion is that a sql row can't be more than 1 mb --- .../database/user/models/CommCareEntityStorageCache.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java b/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java index b0509bf35a..2e12deadf5 100755 --- a/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java +++ b/app/src/org/commcare/models/database/user/models/CommCareEntityStorageCache.java @@ -254,9 +254,6 @@ private static String buildKeyNameWhereClause(String[] names) { private static void populateEntitySet(SQLiteDatabase db, String sqlStatement, String[] args, Hashtable entitySet) { - //TODO: This will _only_ query up to about a meg of data, which is an un-great limitation. - //Should probably split this up SQL LIMIT based looped - //For reference the current limitation is about 10k rows with 1 field each. Cursor walker = db.rawQuery(sqlStatement, args); while (walker.moveToNext()) { String entityId = walker.getString(walker.getColumnIndex("entity_key"));