style: change background color to match system #243
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
=======================================
Coverage 95.11% 95.11%
=======================================
Files 23 23
Lines 1126 1126
=======================================
Hits 1071 1071
Misses 55 55 |
| @@ -332,7 +332,7 @@ def restrictConstrainedParameters(self): | |||
| else: | |||
| textCtrl.SetEditable(True) | |||
| # textCtrl.SetBackgroundColour(txtbg) | |||
| textCtrl.SetBackgroundColour(wx.WHITE) | |||
| textCtrl.SetBackgroundColour(wx.SystemSettings.GetColour(wx.SYS_COLOUR_GRAYTEXT)) | |||
There was a problem hiding this comment.
let's wrap this so it only goes grey if we detect that we are in dark mode.
|
@sbillinge Okay, I think this is better. its formatted in the same way as the dataset panels (see code snippet below). Gray text is non-editable by the user which is desired behavior i believe. Test failed... will investigate
|
|
@cadenmyers13 ok, that looks better. Please can you put side-by-side what the current and new-PR versions of those panels are in light mode so we can be sure that also this aspect is not unduly affected? Thx. |
|
@sbillinge Here's the current version. new-PR version ss is above!
|
|
@cadenmyers13 please could you do me a favor and check it over very carefully and circle all the places there are differences in light and dark mode. Thx |
closes #242
See screenshots for how this change affects interface.
dark mode
light mode