Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

± sign in the CSV file #3

Open
theMyth721 opened this issue Nov 15, 2023 · 7 comments
Open

± sign in the CSV file #3

theMyth721 opened this issue Nov 15, 2023 · 7 comments

Comments

@theMyth721
Copy link

Hi

The CSV file for the Moons has this ± sign in between numbers and its extremely difficult to upload.

I am trying to upload into Postgres on my Mac with Table plus,

The JSON and SQL is a bit difficult, because I have my own schema and structure, and it would be very tedious for me to change manually

May i ask what is the point of keeping numbers in this format ?

And would there be a way to change this ?

Thanks

@mkrauskopf
Copy link
Member

Yes. You are probably right. Since we have stripped the ± sign from other formats (JSON and SQL) it should not be part of the final CSV file as well. So I would consider this to be a bug.

I do not use the data myself actively, nor do I work on the project anymore. Probably the easiest would be to run a sed on the current satellites.csv and strip the ±<number> parts.

I might have time next week, but no promise. So the patch/PR is welcomed.

@theMyth721
Copy link
Author

Hey, Thank you so much for getting back to me, So appreciated, I can try doing that myself.
I am not sure what sed is but i just did man sed, and figured it's a stream editor.
If you would tell me the command then i can do this that would be great, otherwise i am trying to figure it out
Thanks

@mkrauskopf
Copy link
Member

sed was just an example. What I mean is to just strip the ±<number> parts. Manually, with the sed, with Vim macro, with your IDE search-and-replace functionality, ... It really does not matter much.

@theMyth721
Copy link
Author

Thank you, I will try and do it

@theMyth721
Copy link
Author

I just want to make sure, if I strip the entire right side after the ±, I hope the number value will be the same ?

@theMyth721
Copy link
Author

theMyth721 commented Nov 15, 2023

I just got it to work in VSCode with this Regex: /±\d*.?\d*/

I am still new to Github and Software Engineering, but Im happy to make the change for you in your file. I am not sure how to do Pull requests properly, but I have updated the file, and I am going to learn this too.

Screenshot 2023-11-15 at 20 05 23

@mkrauskopf
Copy link
Member

It's worth investing in the skill. You can start with the official documentation: Pull requests documentation - GitHub Docs

You can use this issue as your real training ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants