Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] exported pymatgen/structure cannot match exported ase/structure #781

Open
qchempku2017 opened this issue Jan 16, 2025 · 2 comments · Fixed by #782
Open

[BUG] exported pymatgen/structure cannot match exported ase/structure #781

qchempku2017 opened this issue Jan 16, 2025 · 2 comments · Fixed by #782
Labels
bug Something isn't working

Comments

@qchempku2017
Copy link

qchempku2017 commented Jan 16, 2025

Bug summary

Dear dpdata developers,

Recently I'm having an issue exporting structures into pymatgen format, and I'm eagerly looking for your help. Thank you very much in advance!

My system is LixFePO4, comprising of Li, Fe, P and O elements. When exporting into ase/structure, everything worked out fine:

Image

However, as I switched to exporting pymatgen/structure, weird behavior appeared. Some O atom changed position with P atom, and Fe exchanged with Li, giving unreasonable outcome:

Image

I was using pymatgen == 2024.11.13.

dpdata Version

0.2.21

Input Files, Running Commands, Error Log, etc.

Original dpdata system:

rlx-1.zip

exported structure cif files:

rlx-1-exports.zip

Please uncompress.

Steps to Reproduce

Codes I used:

import dpdata as dd
sys = dd.LabeledSystem("./lfp-dpmd-train0/rlx_fin/rlx-1/", fmt="deepmd/npy")
atoms = sys.to("ase/structure")[0]
atoms.write("./lfp-dpmd-relax0/rlx-1-final-ase.cif")
struct = sys.to("pymatgen/structure")[0]
_ = struct.to("./lfp-dpmd-relax0/rlx-1-final-pmg.cif")

Further Information, Files, and Links

No response

@qchempku2017 qchempku2017 added the bug Something isn't working label Jan 16, 2025
@wanghan-iapcm wanghan-iapcm linked a pull request Jan 17, 2025 that will close this issue
@wanghan-iapcm
Copy link
Contributor

will be fixed by #782

@qchempku2017
Copy link
Author

will be fixed by #782

God speed! Appreciate that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants