Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a link to DCO text or bot to comment the plain text of DCO #106

Open
tunnckoCore opened this issue Mar 1, 2019 · 18 comments · May be fixed by #165
Open

Adding a link to DCO text or bot to comment the plain text of DCO #106

tunnckoCore opened this issue Mar 1, 2019 · 18 comments · May be fixed by #165
Labels
wontfix

Comments

@tunnckoCore
Copy link

Because newcomers may not be so familiar with all the things. I can't find any way to find the DCO text. I know what DCO stands for and what is that bot, but someone may not know that, so... it makes friction.

Best would be the bot to comment on the text on failure. Or at least link to always available, for some reason currently I cannot load the https://developercertificate.org/ but it seems up.
@hiimbex
Copy link
Contributor

hiimbex commented Mar 3, 2019 •
edited by unfurl-links bot
Loading

https://developercertificate.org/ works fine for me. PRs welcome to edit the text in the checks DCO creates.

@stale
Copy link

stale bot commented Jun 1, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Jun 1, 2019
@tunnckoCore
Copy link
Author

tunnckoCore commented Jun 2, 2019 •
edited
Loading

yup, for the sake of a better experience of newcomers/beginners vs skilled ones that want to enable DCO.

@stale stale bot removed the wontfix label Jun 2, 2019
@stale
Copy link

stale bot commented Aug 31, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Aug 31, 2019
@tunnckoCore
Copy link
Author

Yes.

@stale stale bot removed the wontfix label Aug 31, 2019
@stale
Copy link

stale bot commented Nov 29, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Nov 29, 2019
@tunnckoCore
Copy link
Author

yup yup

@stale stale bot removed the wontfix label Nov 29, 2019
@stale
Copy link

stale bot commented Feb 27, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Feb 27, 2020
@tunnckoCore
Copy link
Author

Yes.

@stale stale bot removed the wontfix label Feb 27, 2020
@stale
Copy link

stale bot commented May 30, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 30, 2020
@tunnckoCore
Copy link
Author

👍 💯

@stale stale bot removed the wontfix label May 30, 2020
@kisvegabor
Copy link

👍

Allow customization on the comment text would be awesome.

Can we help with sending a PR?

@stale
Copy link

stale bot commented Sep 20, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label Sep 20, 2020
@gr2m
Copy link
Contributor

gr2m commented Sep 20, 2020

hey I've started to help out maintaining DCO. Would you like to send a PR? I promise I won't let it get stale

@stale stale bot removed the wontfix label Sep 20, 2020
@kisvegabor
Copy link

Hi @gr2m,

Meanwhile, we have chosen another solution. 🙁
It's just a simple auto comment to tell people we use DCO.

@tunnckoCore
Copy link
Author

@gr2m just seen that notification. Cool. I may send some PR in the coming weeks.

@stale
Copy link

stale bot commented May 10, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@stale stale bot added the wontfix label May 10, 2021
d3fault pushed a commit to d3fault/dco that referenced this issue Oct 3, 2021
add clarification of what legal effect --signoff is supposed to even …
a10130b 
…have

Fix: dcoapp#106

Signed-off-by: d3fault <[email protected]>
@d3fault d3fault linked a pull request Oct 3, 2021 that will close this issue
Open
d3fault pushed a commit to d3fault/dco that referenced this issue Oct 3, 2021
add clarification of what legal effect --signoff is supposed to even …
cab75c2 
…have

Fix: dcoapp#106

Signed-off-by: d3fault <[email protected]>
d3fault pushed a commit to d3fault/dco that referenced this issue Oct 3, 2021
add clarification of what legal effect --signoff is supposed to even …
6689bc5 
…have

Fix: dcoapp#106

Signed-off-by: d3fault <[email protected]>
@d3fault
Copy link

d3fault commented Nov 8, 2021

This is a much more important issue than you guys are giving it credit! Currently there's no legal binding between --signoff and the DCO!! Requiring people to pass that --signoff flag currently is about as productive as putting a single "1" or "true" variable into a database with absolutely no meaning given to it. I'm sure you put lots of effort into making this bot function........ but without that legal binding it's all for nothing. I submitted a PR #165 as an attempt to create that legal binding, but so far it's just getting ignored. What gives?

Also: I Am Not Lawyer. The "legally binding" text should probably be reviewed by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add clarification of what legal effect --signoff is supposed to even have d3fault/dco
5 participants
@gr2m @tunnckoCore @kisvegabor @d3fault @hiimbex