Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Spec and patch for expanded find_by_sql #2

Open
solnic opened this issue May 17, 2011 · 1 comment
Open

Spec and patch for expanded find_by_sql #2

solnic opened this issue May 17, 2011 · 1 comment

Comments

@solnic
Copy link
Contributor

solnic commented May 17, 2011

So I've decided to take a whack at getting find_by_sql working in a more AR-like fashion, since it appears to be a stopping block for several of us per earlier tickets.

Before getting too far down the wrong path, can you take a look at this spec in my dm-more branch?

http://github.com/nateware/dm-more/commit/e975899a490ef06c6ee559016683e2c235826ac2

Thanks,
Nate


Created by Nate Wiger - 2009-10-09 13:37:28 UTC

Original Lighthouse ticket: http://datamapper.lighthouseapp.com/projects/20609/tickets/1089

@solnic
Copy link
Contributor Author

solnic commented May 17, 2011

Nate, sorry this took me so long to respond to. I must’ve missed this when reviewing tickets.

The behavior you specified looks to be correct. In general the goal with dm-ar-finders, and find_by_sql specifically, is that we get as close behavior as we can to AR finder methods. Of course due to differences in how DM maps properties to columns, I can understand cases where we need to differ, but in general I will always support patches that bring the behavior closer to AR’s.

by Dan Kubb (dkubb)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant