-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling of colon in Azure KeyValueStores #119
Comments
I made a draft PR here #120 |
I would prefer to only allow filename in |
Understood, I will analyze how the other stores are handling colons and post my results in this issue. Please keep the issue open for this, I will close the PR. |
Do you only want to read these keys or also write them? |
We only need to read these keys. At the moment simply adding the colon to the allowed symbols regexp looks promising. Nothing breaks. The only filesystem I know not accepting colon in the filename would be ntfs. |
I would only be 80% on board adding the colon to allowed characters, but what about turning the key validity check on read from an error into a warning? |
Hi everyone,
currently minimalkv prohibits using colon ":" in KeyValueStores due to it not being in VALID_KEY_RE_EXTENDED.
Azure Stores would support colons in their path. As far as I know this is currently impossible to read using minimalkv. I.e. if another application writes a file with a colon, you cannot read this file with minimalkv (no expert here though, maybe there is a way to quote this).
I can create a PR to allow for colons only for Azure stores. Would this be ok or is there a decision not to allow this to keep the allowed filenames uniform between different store classes?
The text was updated successfully, but these errors were encountered: