Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trace headers to http subscriptions #671

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add trace headers to http subscriptions #671

merged 2 commits into from
Jan 13, 2025

Conversation

yaron2
Copy link
Member

@yaron2 yaron2 commented Jan 13, 2025

Related to #355, this PR adds trace headers when present on HTTP requests coming from Dapr. This ask has been a recurring theme among Dapr users.

@yaron2 yaron2 requested review from a team as code owners January 13, 2025 19:44
Signed-off-by: yaron2 <[email protected]>
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.58%. Comparing base (6c59092) to head (7807957).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #671      +/-   ##
==========================================
- Coverage   62.52%   61.58%   -0.95%     
==========================================
  Files          56       58       +2     
  Lines        4139     4298     +159     
==========================================
+ Hits         2588     2647      +59     
- Misses       1425     1521      +96     
- Partials      126      130       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mikeee mikeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@yaron2 yaron2 merged commit 34fd54e into dapr:main Jan 13, 2025
18 of 19 checks passed
@yaron2 yaron2 deleted the trace-1 branch January 13, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants