-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: check for pre-installed dagger #167
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jeremy Adams <[email protected]>
Signed-off-by: Jeremy Adams <[email protected]>
Signed-off-by: Jeremy Adams <[email protected]>
Signed-off-by: Jeremy Adams <[email protected]>
Signed-off-by: Jeremy Adams <[email protected]>
Have to decide what to do if user wants to override version of pre-installed |
I was just thinking about this and wanted to open an issue, when I saw your PR. I think it makes sense to allow users using a pre-installed version, especially when moving to or between environments. The new Depot integration comes to mind: reducing friction when onboarding or just building a PoC is always good. That was part of the appeal when I first gave Depot a try.
A third option (which is what some actions do) is install Dagger in a custom location (eg. tool cache) and use it from there. The action can provide the location as an output if anyone wants to use it/add it to PATH, but in most of the cases, people will probably just want to use it through the action. At some point, it might also make sense to create a separate setup-action for downloading the CLI. |
closes #164