Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull docker image from Amazon ECR #1090

Closed
h2oearth opened this issue Dec 6, 2023 · 2 comments
Closed

Pull docker image from Amazon ECR #1090

h2oearth opened this issue Dec 6, 2023 · 2 comments
Assignees
Labels
type: enhancement New feature or request

Comments

@h2oearth
Copy link

h2oearth commented Dec 6, 2023

For anonymous users of Docker Hub, the rate limit is set to 100 pulls per 6 hours per IP address. This is an issue with large runners or runners that have static IPs. AWS ECR does not have this constraint.

Could you please add the ability to use any given registry, like AWS ECR?

container:
      image: cypress/browsers: latest
      options: --user 1001
@MikeMcC399
Copy link
Collaborator

@h2oearth

According to GitHub documentation Defining the container image:

Use jobs.<job_id>.container.image to define the Docker image to use as the container to run the action. The value can be the Docker Hub image name or a registry name.

It sounds like what you are asking for is already available from GitHub Actions. Would you like to cross-check?

@MikeMcC399 MikeMcC399 added the type: enhancement New feature or request label Dec 7, 2023
@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Dec 8, 2023

According to Cypress documentation Continuous Integration > AWS CodeBuild, Cypress Docker images are also available on the Amazon Elastic Container Registry (ECR) and can be found under https://gallery.ecr.aws/cypress-io.

These images can be used in Cypress GitHub Action workflows, for example:

    container:
      image: public.ecr.aws/cypress-io/cypress/browsers:latest
      options: --user 1001

Since the functionality being requested is already available, I will close this issue.

Refer also to the Docker > Docker Hub rate limit for ways of extending the rate limit.

@MikeMcC399 MikeMcC399 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 8, 2023
@MikeMcC399 MikeMcC399 self-assigned this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants