Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow absolute paths in indexHtmlFile #28324

Merged

Conversation

Roemer
Copy link
Contributor

@Roemer Roemer commented Nov 13, 2023

This fixes #27750 which was broken in #26400

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@jennifer-shehane
Copy link
Member

@Roemer Thanks for the contribution! Could you please sign our CLA?

@Roemer Roemer force-pushed the bugfix/27750-support-absolute-path branch from 26b8620 to 7d3043e Compare November 13, 2023 16:51
@Roemer
Copy link
Contributor Author

Roemer commented Nov 13, 2023

I did now, I also recommited with my github account.

@Roemer Roemer force-pushed the bugfix/27750-support-absolute-path branch 2 times, most recently from 0e7ee2c to d3c3ddd Compare November 14, 2023 09:46
@Roemer Roemer force-pushed the bugfix/27750-support-absolute-path branch 2 times, most recently from 6c3bbd7 to 507ba33 Compare November 15, 2023 16:26
@Roemer Roemer force-pushed the bugfix/27750-support-absolute-path branch from 507ba33 to dc4af35 Compare November 15, 2023 16:38
@jennifer-shehane jennifer-shehane merged commit dcd6a18 into cypress-io:develop Nov 21, 2023
3 of 5 checks passed
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 21, 2023

Released in 13.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 21, 2023
@Roemer Roemer deleted the bugfix/27750-support-absolute-path branch November 21, 2023 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in absolute file path of component-index.html
7 participants