Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm_filter() does too much work #2277

Open
krlmlr opened this issue Jan 5, 2025 · 0 comments
Open

dm_filter() does too much work #2277

krlmlr opened this issue Jan 5, 2025 · 0 comments

Comments

@krlmlr
Copy link
Collaborator

krlmlr commented Jan 5, 2025

dm_apply_filters_impl() should be a reduce(~ dm_get_filtered_table(...)) , not a map(...) , with a suitable ordering of the tables.

Trigger: tidyverse/duckplyr#441 .

Needs duckdb/duckdb-r#949 to show an effect with duckplyr.

For remote databases (and duck tables), perhaps we want to materialize a "skeleton dm", with only the keys?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant