-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show the error and function tab link in the entity card [FUS-97] #1803
Conversation
constructor(message: string, organizationId: string, appDefinitionId: string) { | ||
super(message); | ||
this.isFunctionInvocationError = true; | ||
this.organizationId = organizationId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably bad, but I couldn't figure out a cleaner way to do this without heavily refactoring the entire entity store.
@contentful/team-tolkien Are there flakey component tests, or have I actually somehow changed rich text rendering despite not touching any of that code? |
Mh I saw the Richtext.HR text failing sometimes, so should be flacky :/ |
We have a task for it in the backlog: https://contentful.atlassian.net/browse/TOL-2583 |
Thanks for confirming that I'm not insane (at least not when it comes to this PR). |
packages/reference/src/components/ResourceEntityErrorCard/FunctionInvocationErrorCard.tsx
Outdated
Show resolved
Hide resolved
packages/reference/src/components/ResourceEntityErrorCard/ResourceEntityErrorCard.tsx
Outdated
Show resolved
Hide resolved
packages/reference/src/components/ResourceEntityErrorCard/FunctionInvocationErrorCard.tsx
Outdated
Show resolved
Hide resolved
packages/reference/src/components/ResourceEntityErrorCard/FunctionInvocationErrorCard.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests for the new logic would be great :)
This PR adds error handling for cases when external resources retrieved via function invocation result in an error.
The error message also presents a link to the relevant function invocation log page in the web app so users can debug any issues caused by errors inside their functions.