Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show the error and function tab link in the entity card [FUS-97] #1803

Merged
merged 6 commits into from
Nov 27, 2024

Conversation

Seth-Carter
Copy link
Contributor

@Seth-Carter Seth-Carter commented Nov 25, 2024

This PR adds error handling for cases when external resources retrieved via function invocation result in an error.

The error message also presents a link to the relevant function invocation log page in the web app so users can debug any issues caused by errors inside their functions.

image

@Seth-Carter Seth-Carter requested a review from a team as a code owner November 25, 2024 16:26
constructor(message: string, organizationId: string, appDefinitionId: string) {
super(message);
this.isFunctionInvocationError = true;
this.organizationId = organizationId;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably bad, but I couldn't figure out a cleaner way to do this without heavily refactoring the entire entity store.

@Seth-Carter Seth-Carter requested review from a team and veu November 25, 2024 16:28
@Seth-Carter
Copy link
Contributor Author

@contentful/team-tolkien Are there flakey component tests, or have I actually somehow changed rich text rendering despite not touching any of that code?

@chrishelgert
Copy link
Contributor

@contentful/team-tolkien Are there flakey component tests, or have I actually somehow changed rich text rendering despite not touching any of that code?

Mh I saw the Richtext.HR text failing sometimes, so should be flacky :/

@YvesRijckaert
Copy link
Contributor

@contentful/team-tolkien Are there flakey component tests, or have I actually somehow changed rich text rendering despite not touching any of that code?

Mh I saw the Richtext.HR text failing sometimes, so should be flacky :/

We have a task for it in the backlog: https://contentful.atlassian.net/browse/TOL-2583

@Seth-Carter
Copy link
Contributor Author

@contentful/team-tolkien Are there flakey component tests, or have I actually somehow changed rich text rendering despite not touching any of that code?

Mh I saw the Richtext.HR text failing sometimes, so should be flacky :/

We have a task for it in the backlog: https://contentful.atlassian.net/browse/TOL-2583

Thanks for confirming that I'm not insane (at least not when it comes to this PR).

Copy link
Contributor

@chrishelgert chrishelgert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests for the new logic would be great :)

@Seth-Carter Seth-Carter merged commit 2b52dfd into master Nov 27, 2024
12 checks passed
@Seth-Carter Seth-Carter deleted the FUS-97 branch November 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants