feat: bumping plate to v30 [TOL-1834] #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
aodhagan-cf
commented
Feb 14, 2024
| "@udecode/plate-list": "30.1.2", | ||
| "@udecode/plate-paragraph": "30.1.2", | ||
| "@udecode/plate-reset-node": "30.1.2", | ||
| "@udecode/plate-select": "30.1.2", | ||
| "@udecode/plate-serializer-docx": "23.7.0", |
There was a problem hiding this comment.
A lot of the pasting from word online and google doc break with this update. Probably better to handle in another ticket
aodhagan-cf
commented
Feb 14, 2024
packages/rich-text/src/plugins/Table/withInsertFragmentTable.ts
Outdated
Show resolved
Hide resolved
z0al
reviewed
Feb 15, 2024
| // copied from the 'is-hotkey' library we use for RichText shortcuts | ||
| const IS_MAC = | ||
| typeof window != 'undefined' && /Mac|iPod|iPhone|iPad/.test(window.navigator.platform); | ||
| const mod = IS_MAC ? 'meta' : 'control'; |
There was a problem hiding this comment.
It is not used anymore, highlighting table content in a different way now as the test was breaking due to the CMD+A logic
packages/rich-text/src/plugins/Table/withInsertFragmentTable.ts
Outdated
Show resolved
Hide resolved
packages/rich-text/src/plugins/Table/withInsertFragmentTable.ts
Outdated
Show resolved
Hide resolved
aodhagan-cf
commented
Feb 19, 2024
packages/rich-text/src/plugins/Table/withInsertFragmentTable.ts
Outdated
Show resolved
Hide resolved
z0al
reviewed
Feb 19, 2024
packages/rich-text/src/plugins/Table/withInsertFragmentTable.ts
Outdated
Show resolved
Hide resolved
|
Wonder, how we're gonna merge these 🫠 |
z0al
approved these changes
Feb 19, 2024
| @@ -177,10 +173,15 @@ describe('Rich Text Editor', { viewportHeight: 2000 }, () => { | |||
| ); | |||
| }); | |||
|
|
|||
| it('does not delete table header cells when selecting the whole table', () => { | |||
| it('does not delete table header cells when selecting the whole header row', () => { | |||
There was a problem hiding this comment.
I'd argue this is now a completely different test and probably worth a follow up to see if it's even needed.
There was a problem hiding this comment.
Totally agree, will sync with @colomolo on this tomorrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the plate plugin dependencies for rich text to v30