-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add label "Congratulations, all pictures in this album have been either uploaded or marked as not for upload." #5619
Comments
Can we either display "An vector" like this? If no image is left to upload or masked as not for upload, we can display svg image & display text like
What do you think about it @nicolas-raoul. I can tackle this while my wikimedia id is banned. |
@neeldoshii Sorry for the delay! Yes vetor image would be nice, if possible. "Congratulations": Even marking all pictures as not for upload is good, so I think it is a good opportunity to make people feel good. :-) Maybe something like "Good job! [...]" Maybe it could even suggest the user to perform peer reviews or go take nearby pictures, with buttons to launch these activities. |
I would like to try to solve this problem. Would you like to assign it to me? |
Are you still working on this issue ? |
Yes. However, based on my limited skills, it might take me sometime. |
@Thejas775 Thanks for your enthusiasm, however better work on unassigned bugs (the app has enough bugs for everybody haha) next time. @starrain1031 Sorry for unusual workflow this time. Maybe review Thejas775's pull request, improve it if possible, then work on a second bug if you want? :-) |
I'm really sorry but this was my first contribution to open source as well. This was a good first issue that I thought I could solve. |
@Thejas775 That's understandable :-) You might want to read https://github.com/commons-app/commons-app-documentation/blob/master/android/Volunteers-welcome!.md#developers which has the link to unassigned bugs. I hope you will enjoy fixing other bugs :-) |
Will follow the workflow from next time. |
Yeah sure seems intresting. |
@starrain1031 Any progress on this? :-) |
If @starrain1031 is not working on this. I can do this. |
@AlexD4110 Thanks for your enthusiasm! I just assigned you to the other issue, when done please ask again here. Thanks a lot! :-) |
Hi, can i work on this issue @nicolas-raoul |
In the custom picker, with "Show already actioned pictures" disabled, this is how the screen looks after all pictures have been either uploaded or marked as not for upload:
Ideally, it should instead display a message such as:
"Congratulations, all pictures in this album have been either uploaded or marked as not for upload."
The text was updated successfully, but these errors were encountered: