rebase: update csi-resizer to v1.13.1 #5071
Conversation
nixpanic
added
the
ci/skip/multi-arch-build
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
It seems the new container-image is not available in the registry yet. |
nixpanic
force-pushed
the
sidecars/external-resizer/v1.13.0
branch
from
d24e408 to
c8bfab2
Compare
nixpanic
changed the title
v1.13.0 failed to build and could not be pushed to the release repository, v1.13.1 contains the release-tools fixes and is now available. |
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
nixpanic
force-pushed
the
sidecars/external-resizer/v1.13.0
branch
from
c8bfab2 to
9a64ee4
Compare
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.30 |
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
|
/test ci/centos/k8s-e2e-external-storage/1.31 |
|
/test ci/centos/mini-e2e-helm/k8s-1.30 |
|
/test ci/centos/mini-e2e-helm/k8s-1.32 |
|
/test ci/centos/mini-e2e-helm/k8s-1.31 |
|
/test ci/centos/mini-e2e/k8s-1.30 |
|
/test ci/centos/mini-e2e/k8s-1.32 |
|
/test ci/centos/mini-e2e/k8s-1.31 |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
Interesting failure in the CI: Offline PVC expansion is not expected to work if the PVC has a filesystem on it 🤔 |
|
@nixpanic https://kubernetes.slack.com/archives/C09QZFCE5/p1736798710626099 it looks like its broken. why its running offline expansion for ceph-csi, should we disable it as we don't support it? |
Yeah, I also wonder why it would run. Will look into it soonish. Maybe it is because |
The Kubernetes CSI community has released an updated external-resizer sidecar that fixes some issues and adds a few improvements. See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1 Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
sidecars/external-resizer/v1.13.0
branch
from
9a64ee4 to
3c37350
Compare
mergify
bot
dismissed stale reviews from Madhu-1 and Rakshith-R
Pull request has been modified.
scripts/k8s-storage/driver-rbd.yaml
Outdated
| # Support for volume expansion in controllers | ||
| controllerExpansion: true | ||
| # Support for volume expansion in controllers (only for RBD with BlockMode) | ||
| controllerExpansion: false |
There was a problem hiding this comment.
@nixpanic we still need this to set to true for filesystem as well as it needs both controllerExpansion and filesystem resize as well?
There was a problem hiding this comment.
https://github.com/kubernetes/kubernetes/blob/ec2e0de35a298363872897e5904501b029817af3/test/e2e/storage/framework/testdriver.go#L193 this need to be set to false as its enabled by default?
There was a problem hiding this comment.
yeah, the options are a bit confusing, and their documentation could be better... I now found an offlineExpansion option, maybe that is more suitable.
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
The `offlineExpansion` option enables tests that try to expand volumes in the CSI Controller (provisioner). This is only possible for BlockMode volumes, as a FileMode volume needs run a filesystem resizer while the volume is attached. Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
sidecars/external-resizer/v1.13.0
branch
from
3c37350 to
dbb2cd3
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.32 |
The Kubernetes CSI community has released an updated external-resizer
sidecar that fixes some issues and adds a few improvements.
See: https://github.com/kubernetes-csi/external-resizer/releases/tag/v1.13.1