Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark the CheckTx after adding the mempool mutexes in core #4217

Closed
rach-id opened this issue Jan 13, 2025 · 2 comments
Closed

benchmark the CheckTx after adding the mempool mutexes in core #4217

rach-id opened this issue Jan 13, 2025 · 2 comments
Assignees

Comments

@rach-id
Copy link
Member

rach-id commented Jan 13, 2025

After implementing celestiaorg/celestia-core#1582 and depending on it in #4197, we should benchmark the CheckTx to how much delay is being added with the new mutexes.

This issue blocks the v3.2.1 release.

@rach-id rach-id self-assigned this Jan 13, 2025
@evan-forbes
Copy link
Member

to be extra specific, the main concern we have is with rechecktx. If the mempool is very large and we're blocking memool access the entire time, then it could block proposers from reaping from the mempool to create a block.

@rach-id
Copy link
Member Author

rach-id commented Jan 16, 2025

After running the benchmarks under app/benchmarks using the recheck type, we found out that for msg send, for example, rechecking an 8mb block takes ~2s, which is good. So, we can close this issue

@rach-id rach-id closed this as completed Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants