Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt the packet forward middleware #2831

Closed
evan-forbes opened this issue Nov 8, 2023 · 6 comments · Fixed by #3084
Closed

Adopt the packet forward middleware #2831

evan-forbes opened this issue Nov 8, 2023 · 6 comments · Fixed by #3084
Assignees
@ninabarbakadze
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules WS: V2 ✌️ lemongrass hardfork related
Milestone
v2

Comments

@evan-forbes
Copy link
Member

A common feature request for teams building on IBC is for the PFM to be added to the middleware of celestia-app
@evan-forbes evan-forbes added this to the v2 milestone Nov 8, 2023
@rootulp
Copy link
Collaborator

rootulp commented Nov 8, 2023 •
edited
Loading

Ref:

@rootulp
Copy link
Collaborator

rootulp commented Nov 16, 2023

Based on a synchronous discussion I think we want to hold off on tackling this until a CIP is written.

@rootulp
Copy link
Collaborator

rootulp commented Jan 29, 2024 •
edited
Loading

Update: CIP-9 exists and it is in Review status.

@ninabarbakadze ninabarbakadze self-assigned this Feb 1, 2024
@danburck
Copy link

danburck commented Feb 1, 2024

Looking forward to this

@rootulp rootulp added WS: V2 ✌️ lemongrass hardfork related consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules and removed apphash breaking labels Mar 1, 2024
@ninabarbakadze
Copy link
Member

pfm has not been audited, pausing work on this for now.

@ninabarbakadze
Copy link
Member

decided to resume work on pfm, since it's been integrated and tested by multiple other major projects.

@ninabarbakadze ninabarbakadze mentioned this issue Apr 2, 2024
Merged
ninabarbakadze added a commit that referenced this issue Apr 3, 2024
@ninabarbakadze
feat!: add packet forward middleware (#3084)
ed91647 
closes #2831 
opens #3241

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ninabarbakadze ninabarbakadze

Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules WS: V2 ✌️ lemongrass hardfork related
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

feat!: add packet forward middleware ninabarbakadze/celestia-app
4 participants
@rootulp @danburck @evan-forbes @ninabarbakadze