You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We don't plan on modifying the crypto/merkle package, however that package needs to have its own go module so that users can import it without needing the rest of tendermint.
That could involve moving that package into the pkg here, or just adding a go module to that package in core. The issue with adding a go module in core is that the module's path would have to be celestiaorg/celestia-core unless we wait for upstream to do this. If we wanted to get the benefits of not copying code, we'd have also change all of the references to that code to also point to the new module.
for now, I'm planning on just moving the package here in our pkg directory, but this will likely change in an upcoming refactor to the module in pkg#2570
The text was updated successfully, but these errors were encountered:
We don't plan on modifying the crypto/merkle package, however that package needs to have its own go module so that users can import it without needing the rest of tendermint.
That could involve moving that package into the
pkg
here, or just adding a go module to that package in core. The issue with adding a go module in core is that the module's path would have to be celestiaorg/celestia-core unless we wait for upstream to do this. If we wanted to get the benefits of not copying code, we'd have also change all of the references to that code to also point to the new module.for now, I'm planning on just moving the package here in our
pkg
directory, but this will likely change in an upcoming refactor to the module inpkg
#2570The text was updated successfully, but these errors were encountered: