Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the merkle package to a go.mod that doesn't import tendermint/core #2769

Closed
evan-forbes opened this issue Oct 25, 2023 · 1 comment
Closed
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@evan-forbes
Copy link
Member

We don't plan on modifying the crypto/merkle package, however that package needs to have its own go module so that users can import it without needing the rest of tendermint.

That could involve moving that package into the pkg here, or just adding a go module to that package in core. The issue with adding a go module in core is that the module's path would have to be celestiaorg/celestia-core unless we wait for upstream to do this. If we wanted to get the benefits of not copying code, we'd have also change all of the references to that code to also point to the new module.

for now, I'm planning on just moving the package here in our pkg directory, but this will likely change in an upcoming refactor to the module in pkg #2570

@evan-forbes evan-forbes added dependencies Pull requests that update a dependency file and removed needs:triage labels Oct 27, 2023
@cmwaters cmwaters self-assigned this Jan 3, 2024
@rootulp
Copy link
Collaborator

rootulp commented Feb 22, 2024

I think this was completed when go-square was extracted. See https://github.com/celestiaorg/go-square/tree/main/merkle
@cmwaters please re-open if that's not the case.

@rootulp rootulp closed this as completed Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants