Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the prebuilt binaries #2737

Closed
evan-forbes opened this issue Oct 20, 2023 · 4 comments
Closed

Test the prebuilt binaries #2737

evan-forbes opened this issue Oct 20, 2023 · 4 comments
Labels
CI item that directly relates to or modify the CI

Comments

@evan-forbes
Copy link
Member

The prebuilt binaries were/are not working, so we should have tests that can detect this. Ideally these tests would include

  • using a mock ledger
  • running the same prebuilt on all of the supported versions/distros
  • start a single validator network
@evan-forbes evan-forbes added the CI item that directly relates to or modify the CI label Oct 20, 2023
@rootulp
Copy link
Collaborator

rootulp commented Oct 20, 2023

A prerequisite to this issue is defining all supported versions / architectures / distributions

@evan-forbes
Copy link
Member Author

I'm good with just the existing ubuntu and mac latest just to get the infrastructure up, and then we can add others. Would love to support the latest arch, nix, and bsd eventually

@rootulp
Copy link
Collaborator

rootulp commented Oct 20, 2023

Created #2742 which we should tackle before this issue

@rootulp
Copy link
Collaborator

rootulp commented Dec 15, 2023

I agree with the motivation for this issue but closing b/c we discussed in person that it currently isn't worth investing in testing Ledger support on the pre-built binaries because the proposed mechanisms to do so: mock Ledger aren't as reliable as literally testing with a real Ledger.

It's far from ideal but we currently get signal from users if Ledger stops working on a prebuilt binary. We have a dedicated test to make sure that celestia-app can build with Ledger support (doesn't cover pre-built binaries) but that has already caught a few regressions.

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI item that directly relates to or modify the CI
Projects
None yet
Development

No branches or pull requests

2 participants