-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test the prebuilt binaries #2737
Comments
A prerequisite to this issue is defining all supported versions / architectures / distributions |
I'm good with just the existing ubuntu and mac latest just to get the infrastructure up, and then we can add others. Would love to support the latest arch, nix, and bsd eventually |
Created #2742 which we should tackle before this issue |
I agree with the motivation for this issue but closing b/c we discussed in person that it currently isn't worth investing in testing Ledger support on the pre-built binaries because the proposed mechanisms to do so: mock Ledger aren't as reliable as literally testing with a real Ledger. It's far from ideal but we currently get signal from users if Ledger stops working on a prebuilt binary. We have a dedicated test to make sure that celestia-app can build with Ledger support (doesn't cover pre-built binaries) but that has already caught a few regressions. |
The prebuilt binaries were/are not working, so we should have tests that can detect this. Ideally these tests would include
The text was updated successfully, but these errors were encountered: