Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blobstream breaking renaming changes #2733

Closed
rach-id opened this issue Oct 20, 2023 · 1 comment
Closed

Blobstream breaking renaming changes #2733

rach-id opened this issue Oct 20, 2023 · 1 comment
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules warn:api breaking item will be break an API and require a major bump x/blobstream item is directly relevant to the blob module
Milestone
v2

Comments

@rach-id
Copy link
Member

rach-id commented Oct 20, 2023 

          to clarify the smallest bit, we want to add the consensus breaking things, but we first need the infra to be able to test the upgrade/migrations

Also, if we don't already have an issue for that, can we get one?

Originally posted by @evan-forbes in #2724 (comment)
@rach-id rach-id added consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules warn:api breaking item will be break an API and require a major bump x/blobstream item is directly relevant to the blob module and removed needs:triage labels Oct 20, 2023
@rach-id rach-id mentioned this issue Oct 20, 2023
Merged
5 tasks
@rach-id rach-id changed the title Add Blobstream breaking changes once the infra allows it Add Blobstream breaking renaming changes once the infra allows it Nov 9, 2023
@rach-id rach-id changed the title Add Blobstream breaking renaming changes once the infra allows it Blobstream breaking renaming changes Nov 9, 2023
@rach-id rach-id added this to the v2 milestone Nov 9, 2023
@rach-id
Copy link
Member Author

rach-id commented Feb 21, 2024

no longer needed as we're switching to BlobstreamX

@rach-id rach-id closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
consensus breaking modifies block validity rules in a way that will break consensus unless all nodes update their rules warn:api breaking item will be break an API and require a major bump x/blobstream item is directly relevant to the blob module
Projects
None yet
Milestone
v2
Development

No branches or pull requests
1 participant
@rach-id