Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keypoints and objectives are missing in episode 6 #89

Closed
bencomp opened this issue Jul 27, 2023 · 2 comments
Closed

Keypoints and objectives are missing in episode 6 #89

bencomp opened this issue Jul 27, 2023 · 2 comments

Comments

@bencomp
Copy link
Contributor

bencomp commented Jul 27, 2023

In episode 6, The Carpentries Git Workflow, the learning objectives and keypoints are both "List Here". I wanted to suggest some based on the contents and the questions, but then I realised that the focus of the narrative may not really answer the questions. I don't see anything about reviewing pull requests (except for a link to GitHub's documentation) and making changes to pull requests is not mentioned at all.

This is a (presumably) known issue that I just wanted to highlight. This issue could in a way be considered a duplicate of #37, which discusses what technical topics should be discussed in this lesson. (Maintainers are probably also aware of the need to update references to the gh-pages branch, now that The Workbench is in use and all changes should go to the main branch. That is a different issue.)

@tobyhodges
Copy link
Member

Closed by #99

@tobyhodges
Copy link
Member

Reviewing and editing PRs are covered in the separate GitHub skill-up for Maintainers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants