Some features to consider #677
billgraziano
started this conversation in
Ideas
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
I recently started working with this app and it is really doing well for me. I ended up needing a few extra features, so I forked it. I'm not sure if these are things you'd like to add back to the original or not. I didn't want to submit them without testing and asking first. Plus, I'm a DBA and my GO skills reflect it 😄
I changed it to always show a timestamp in the exported metrics. This may show my lack of knowledge around Prometheus. DevOps polls my sql_exporter instance every 10s-30s. I don't think I want numbers that often, so I cache the results for 55 seconds. But I'm not sure if reporting the same value multiple times will create multiple entries in Prometheus -- which aren't correct. So, I always add a timestamp at the point it was generated.
I setup it up to log to a file name with YYYY_MM appended. I didn't like appending the log file forever and I didn't want one file per run. But this isn't really right when it crosses month-end. But it's good enough. It likely isn't what "container" people need. I'm not sure what's right.
I added code to prefer the timestamp sent from the database server. My example is the CPU measurement from inside the ring buffer. It only writes once per minute, and I want to use that time stamp. It also sends a value if the timestamp from the server is invalid -- which should never happen.
Beta Was this translation helpful? Give feedback.
All reactions