Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pylint #395

Open
nickzuber opened this issue Jul 25, 2017 · 1 comment
Open

Update Pylint #395

nickzuber opened this issue Jul 25, 2017 · 1 comment

Comments

@nickzuber
Copy link
Contributor

nickzuber commented Jul 25, 2017

Our current version of pylint is slightly out of date and we're missing out on some bug fixes from the newer versions.

❯ pylint --version
pylint 1.6.5, 
astroid 1.4.0

One example is #394 (diff)
in our code where there's a problem with type annotating tuples. More about that particular issue can be found at pylint-dev/pylint#1212

We should update pylint at some point and then remove the disable workarounds. The particular issue mentioned here looks like it was fixed in version 1.5 for astroid.

@cmcginty
Copy link
Contributor

I did a pylint upgrade for werk a while back. See https://github.com/box/werk/pull/868
The one thing missing however was pinning astroid and isort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants