Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2024-0379: Multiple soundness issues #4033

Closed
github-actions bot opened this issue Nov 10, 2024 · 5 comments
Closed

RUSTSEC-2024-0379: Multiple soundness issues #4033

github-actions bot opened this issue Nov 10, 2024 · 5 comments

Comments

@github-actions
Copy link

Multiple soundness issues

Details
Status unsound
Package fast-float
Version 0.2.0
URL aldanor/fast-float-rust#35
Date 2024-10-31

fast-float contains multiple soundness issues:

  1. Undefined behavior when checking input length, which has been merged but no package pubished.
  2. Many functions marked as safe with non-local safety guarantees

The library is also unmaintained.

Alternatives

For quickly parsing floating-point numbers third-party crates are generally no longer needed. A fast float parsing algorithm by the author of lexical has been merged into libcore. When requiring direct parsing from bytes and/or partial parsers, the fast-float2 fork of fast-float containing these security patches and reduces overall usage of unsafe.

See advisory page for additional details.

@storopoli
Copy link

This crate should move from fast-float which is abandoned to fast-float2

@4yman-0
Copy link
Contributor

4yman-0 commented Dec 2, 2024

Close this issue please. boa already uses fast-float2 (in main at least).

@storopoli
Copy link

No don't close this issue before tagging a new release.
This is the latest release Cargo.toml:

boa/Cargo.toml

Line 58 in 59a7c02

fast-float = "0.2.0"

@nick42d
Copy link

nick42d commented Dec 15, 2024

I believe this can be closed now that v0.20.0 has been released. https://github.com/boa-dev/boa/releases/tag/v0.20

@HalidOdat
Copy link
Member

Yup, this is done in #4052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants