Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Goat migrate failing to deactivate old host #878

Open
timonsku opened this issue Dec 16, 2024 · 6 comments
Open

Goat migrate failing to deactivate old host #878

timonsku opened this issue Dec 16, 2024 · 6 comments

Comments

@timonsku
Copy link

I tried to migrate an account from the bsky PDS to my own PDS yesterday. It seems to have mostly succeed but it did fail at the step to deactivate the "old host" (I assume the old PDS?)
I was able to login into the web app using the new PDS and I could not spot anything that would indicate something having been broken.
What exactly is that failed step, does that just remove the DID from the old PDS, is it crucial or just clean up?
It looks like it was the last step looking at the source, so other than that it appears to have succeeded?

Here the log (shortened the blob transfer bit)

>  goat account migrate --pds-host "pds.timonsku.zip" ....
2024/12/16 04:00:28 INFO new host serviceDID=did:web:pds.timonsku.zip url=https://pds.timonsku.zip
2024/12/16 04:00:28 INFO creating account on new host handle=diodes-delight.com host=https://pds.timonsku.zip
2024/12/16 04:00:30 INFO migrating repo
2024/12/16 04:00:31 INFO migrating preferences
2024/12/16 04:00:31 INFO migrating blobs
2024/12/16 04:00:33 INFO transferred blob cid= ...
...
2024/12/16 04:00:41 INFO account migration status status="&{Activated:false ExpectedBlobs:6 ImportedBlobs:6 IndexedRecords:38 PrivateStateValues:0 RepoBlocks:52 RepoCommit:bafyreih74rojbmskwdqaiqi2mmuarjai5drehvccmd4gv43oozsjnelfta RepoRev:3ldfdl5thac2j ValidDid:false}"
2024/12/16 04:00:41 INFO updating identity to new host
2024/12/16 04:00:42 INFO activating new account
error: failed deactivating old host: XRPC ERROR 401: BadJwtSignature: jwt signature does not match jwt issuer
@bnewbold
Copy link
Collaborator

hmmm, I thought we had fixed this over in bluesky-social/atproto#3173, but maybe not?

cc: @devinivy

@timonsku
Copy link
Author

My goat version is v0.0.0-20241212185500-749cc07bf4eb if that helps

@bnewbold
Copy link
Collaborator

the fix is on the PDS/entryway side, and the linked PR never actually got deployed. will go out soon and that should resolve it.

thanks for reporting!

@timonsku
Copy link
Author

Sounds good! Just wanted to double check, do I need to still do something in this case to clean up the bsky PDS side? Don't want to create headache for the bsky team with some DID being served from two places or whatever is still left before deactivation

@bnewbold
Copy link
Collaborator

This fix was deployed on Monday (Dec 16th). I will keep this open until I get a chance to confirm the full migration flow is smooth.

@timonsku you should still deactivate the old account. You can try to do this using goat (following the "manual" instructions in the blog post), or you can use the bsky app itself to log in to the old PDS, then go to settings and deactivate account. Users on the same bsky PDS (out of the fleet of ~40 "mushroom" PDS instances) might have trouble interacting with your account if you don't (as a separate bug).

@mackuba
Copy link

mackuba commented Jan 5, 2025

the fix is on the PDS/entryway side, and the linked PR never actually got deployed. will go out soon and that should resolve it.

thanks for reporting!

Oooh, so that's why I had this issue when I tested migration on a test account before holidays, but I couldn't reproduce it when testing again this week… :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants