-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode feature #126
Comments
I love that idea! 😻 Maybe it's time for a big redesign as the site has not changed since the beginning. Another reason is the consistency with Best of JS app, where we have a dark mode. Let me finish an experiment I'm doing with the framework Astro because we need to have a stable foundation: |
About the Astro way to handle the theme, this template uses a vanilla JS solution, with a custom element We could use |
I watched a few videos about Astro and did some reading. My interest is rising! it is very cool how flexible Astro can be. Write HTML/CSS by default and if you NEED to use JS or dynamic content, it can be used in isolation in the areas where it is needed! I am curious, it sounds like you are hesitant about introducing React to Astro. Is there a reason as to why we shouldn't? |
In principle, to build pages you work mainly with This pattern is great if you need a specific widget somewhere in your page, you can make the JavaScript loaded only when the widget is revealed in the page. Another point is that I wanted to add interactivity using |
I think it would be great to have the option to view in dark mode. Generally users prefer having the ability to use dark or light mode. Dark mode is a pretty common thing for most websites these days and having this option only makes the website more popular (Which we want!). I personally found my eyes getting a bit tired half way through the article. Also there was a comment from one of ThePrimeTime's viewers in his 2023 JS rising Stars video that inspired me to create this issue 😆
If dark mode is something we can add I would be interested in working on this and happy to discuss more 👍
The text was updated successfully, but these errors were encountered: