Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables in configs not user-friendly #59

Open
fabioseel opened this issue Oct 30, 2024 · 1 comment
Open

Variables in configs not user-friendly #59

fabioseel opened this issue Oct 30, 2024 · 1 comment
Labels
Enhancement Improve an existing feature Refactor Improving code without changing function

Comments

@fabioseel
Copy link
Contributor

Still not sure how to feel about referencing those variables here and thus forcing the experiment config to set them. This is somewhat obscure and non intuitive.
However, I'm also not fundamentally happy about the alternative (just have defaults here and overwrite them in the experiment config) - even though it's more explicit and imho easier to use at first sight, intrinsic dependencies (eg vision_height and _width definition between model and dataset needs to match) can easily be messed up (but this also applies for the current system.

In general, I think this is user unfriendly and we should rediscuss and fix this somehow.

@fabioseel fabioseel added Refactor Improving code without changing function Enhancement Improve an existing feature labels Oct 30, 2024
@alex404
Copy link
Contributor

alex404 commented Oct 30, 2024

Yah I have thoughts about this too but its not urgent. We can discuss next time it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improve an existing feature Refactor Improving code without changing function
Projects
None yet
Development

No branches or pull requests

2 participants