-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider using tink_multipart #7
Comments
This would be great. The differences that come to mind are a 76 character line limit and we need to be able to set additional headers for every chunk. |
What is the line limit? Can we just split it while piping? |
I wasn't completely correct, the rfc says:
Split while piping should work, while inserting CRLF after every 78 characters. |
Ok now it should be able to construct arbitrary parts, |
I'll give this a go next week. Thinking of eliminating the tink_await dependency and the queue too. |
This is on its way in the next branch. I removed await dependency, added base for proper testing, attachments are now streaming and changed the api so it's not dealing with an internal queue, and it's easier to deal with connection errors. SmtpMailer.connect({
host: 'localhost',
port: 1025
}).next(mailer ->
mailer.send(email).next(
_ -> mailer.close()
);
); There's more to do so leaving a note for future me:
|
I noticed that both smtpmailer and tink_multipart have advanced a fair bit beyond their last haxelib releases (0.4.0 and 0.3.0 respectively). Are the git versions stable? |
Ever since using lix I've not really been updating haxelib releases to be honest. I am using current master instead of haxelib releases in production. |
@benmerckx Can you at least consider creating Git version tags? I'm not very comfortable using "insert git ref" releases... |
@cedx done. Released to haxelib too. |
Thanks a lot! |
No description provided.
The text was updated successfully, but these errors were encountered: