Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredentialsProvider should be an interface #252

Closed
aajtodd opened this issue Nov 16, 2020 · 2 comments
Closed

CredentialsProvider should be an interface #252

aajtodd opened this issue Nov 16, 2020 · 2 comments
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue

Comments

@aajtodd
Copy link
Contributor

aajtodd commented Nov 16, 2020

Currently CredentialsProvider is an abstract base class that expects sub-classes to be native implementations.

This prevents a library from providing a pure Java/Kotlin implementation of a credentials provider.

This should be refactored to an interface and the abstract base class can be made internal. The implementation will need to provide a bridge that wraps externally provided providers that proxies to C and back.

@bretambrose bretambrose added the feature-request A feature should be added or improved. label Nov 25, 2020
@bretambrose
Copy link
Contributor

On the surface, this seems very reasonable. We may not get to it for some time though.

@yasminetalby yasminetalby added needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue labels Oct 4, 2023
@jmklix
Copy link
Member

jmklix commented May 6, 2024

Closing. Use delegate credentials provider for similar functionality

@jmklix jmklix closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member. p3 This is a minor priority issue
Projects
None yet
Development

No branches or pull requests

4 participants