You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, I'm working on adding a set of perovskite synthesis reactions to src/olympus/datasets as a benchmark dataset (following a previous discussion with @jschrier earlier this month). A brief description of this dataset can be found here.
Questions:
It appears all of the benchmark datasets currently in src/olympus/datasets have continuous targets, but our synthesis dataset has a categorical target. Is this a problem?
What is the best practice to include descriptors for categorical parameters? (I see you have a descriptor.csv in this folder, but would it be better to just include the descriptors directly like this?)
The text was updated successfully, but these errors were encountered:
Thanks for pointing this out. We actually don't currently support categorical targets, but this could be something that we implement in Olympus moving forward. I'd be happy to discuss this further with you such that we can include your synthesis dataset.
Conventionally, we include descriptors using the following convention: a csv file whose columns (from left to right) correspond to the categorical parameter name (e.g., organic), the option name (e.g., ethylammonium), the descriptor name (e.g., homo), and the descriptor value (e.g, -0.46). I realize this format is perhaps slightly unconventional, but I've found it streamlines organizing the Dataset instance. Would be happy to discuss potential ways of further improving this.
Hey, I'm working on adding a set of perovskite synthesis reactions to
src/olympus/datasets
as a benchmark dataset (following a previous discussion with @jschrier earlier this month). A brief description of this dataset can be found here.Questions:
src/olympus/datasets
have continuous targets, but our synthesis dataset has a categorical target. Is this a problem?descriptor.csv
in this folder, but would it be better to just include the descriptors directly like this?)The text was updated successfully, but these errors were encountered: