Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused variable in Hummer cross-section #2

Open
epassaro opened this issue Aug 20, 2021 · 2 comments
Open

Unused variable in Hummer cross-section #2

epassaro opened this issue Aug 20, 2021 · 2 comments

Comments

@epassaro
Copy link

I think this variable is not used inside the function:

artisatomic/artisatomic/readhillierdata.py

Line 885 in 4959ba9

thresholddivenergy = energydivthreshold ** -1

lukeshingles added a commit that referenced this issue Aug 24, 2021
@lukeshingles
Fix issue #2
9aef4b9
@lukeshingles
Copy link
Member

Ok, thanks! Line is removed. Any clues about whether the rest of the function is correct? I see a note that I could not find what the h parameter was supposed to do.

@epassaro
Copy link
Author

I didn't have time to review any paper yet, and I'm not sure If I can do it anytime soon. Maybe Andreas or Christian can give us a quick answer about that.

This is the paper I marked as a reference for that function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lukeshingles @epassaro