fix: Prevent undo functionality from referencing incorrect dashboard edits #31809
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rryover issues. Ensure undo actions apply only to the current dashboard.
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
 |
Improper Redux State Mutation ▹ view | ✅ |
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
Comment on lines
270
to
275
| export function resetDashboardPast() { | ||
| return (dispatch, getState) => { | ||
| const { dashboardLayout } = getState(); | ||
| dashboardLayout.past = []; // Set `past` as an empty array | ||
| }; | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
@fardin-developer I don't think you should edit the state here? Why not in the reducers?
There was a problem hiding this comment.
clearing history from redux undo
justinpark
reviewed
Jan 15, 2025
| @@ -668,6 +673,7 @@ const Header = () => { | |||
| NavExtension, | |||
| boundActionCreators.onRedo, | |||
| boundActionCreators.onUndo, | |||
| boundActionCreators.clearDashboardHistory(), | |||
There was a problem hiding this comment.
You're executing the function in the dependent list
Suggested change
| boundActionCreators.clearDashboardHistory(), | |
| boundActionCreators.clearDashboardHistory, |
|
Looks great, once Justin’s comment is addressed it’s good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31344
Description
This PR fixes a bug where the "Undo" button displays actions from a previously edited dashboard after switching to a new one. The issue occurred because the dashboardLayout.past array, which stores the undo history, was not cleared when switching between dashboards or entering edit mode.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
https://drive.google.com/file/d/1ddAJXwsBFAmTHtpjKqo-fRAzk6fu4aek/view?usp=sharing
After
https://drive.google.com/file/d/1fvomN09d4G_87We-YfOaAurMTTcQ7dAO/view?usp=sharing
Key Changes:
Reset Dashboard History:
Introduced the resetDashboardPast function to ensure the dashboardLayout.past array is cleared when toggling edit mode.
Edit Button Update:
Updated the "Edit Dashboard" button to call the resetDashboardPast function via boundActionCreators.clearDashboardHistory() when clicked.
Reproduction Steps
Expected Behavior: