Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support - negativeAckRedeliveryDelay and AckTimeout in ConsumerOptions #46

Open
dionjansen opened this issue Jun 24, 2020 · 3 comments · May be fixed by #83
Open

Support - negativeAckRedeliveryDelay and AckTimeout in ConsumerOptions #46

dionjansen opened this issue Jun 24, 2020 · 3 comments · May be fixed by #83
Labels
enhancement New feature or request

Comments

@dionjansen
Copy link
Contributor

As part of the consumer configuration options, it would be great if you can configure:

  • negativeAckRedeliveryDelay: Delay to wait before redelivering messages that failed to be processed.
  • ackTimeout: Timeout of unacked messages
@dionjansen dionjansen mentioned this issue Jun 25, 2020
Open
@blankensteiner
Copy link
Contributor

Hi @dionjansen
It's not something I will be using myself, but I'm open for a discussion about how to implement it and of course to review and merge the PR, if you are up for creating one :-)

@blankensteiner blankensteiner added the enhancement New feature or request label Dec 12, 2020
@dionjansen dionjansen mentioned this issue Dec 21, 2020
Closed
dionjansen added a commit to dionjansen/pulsar-dotpulsar that referenced this issue Jul 23, 2021
@dionjansen
feat: apache#46 support nack delay and ack timeouts
667a58e 
* feat: apache#45 `Consumer` now supports `NegativeAcknowledge`
* add `AcknowledgementTimeout` to `ConsumerOptions`
* add `NegativeAcknowledgementRedeliveryDelay` to `ConsumerOptions`
* add `NegativeackedMessageState` to manage nacked messages
* add `UnackedMessageState` to manage unacked messages
* add `MessageTracker` to periodically check unacked and nacked messages, on a fixed polling timeout of 10ms
* add `AwaitingAck` to track both unacked and nacked messages
* add `InactiveMessageTracker` to reduce overhead when no `AcknowledgementTimeout` or `NegativeAcknowledgementRedeliveryDelay` is configured
* add `InactiveNegativeackedMessageState` to reduce overhead when no `NegativeAcknowledgementRedeliveryDelay` is configured
* add `InactiveUnackedMessageState` to reduce overhead when no `AcknowledgementTimeout` is configured
* update `ConsumerBuilder` to allow setting `AcknowledgementTimeout`
* update `ConsumerBuilder` to allow setting `NegativeAcknowledgementRedeliveryDelay`
* refactor `ConsumerChannel` to support `NegativeAcknowledge`
* refactor `AsyncQueue<T>` to implement missing interface `IAsyncQueue<T>`
* refactor `BatchHandler<TMessage>` to implement missing interface `IBatchHandler<TMessage>`
* add `AutoFixture` and `AutoFixture.AutoNSubstitute` dependencies to unit test project
* add missing `ConsumerBuilderTests` unit tests
* add missing `ConsumerChannelFactoryTests` unit tests
* add missing `ConsumerChannelTests` unit tests
* add missing `ConsumerTests` unit tests
* add IntegrationTests for consumer ack timout and nack delays
* skipped integration test `SinglePartition_WhenSendMessages_ThenGetMessagesFromSinglePartition` to avoid CI failures
* skipped integration test `RoundRobinPartition_WhenSendMessages_ThenGetMessagesFromPartitionsInOrder` to avoid CI failures

Closes: apache#46
Closes: apache#45
@dionjansen dionjansen linked a pull request Jul 23, 2021 that will close this issue
Open
dionjansen added a commit to dionjansen/pulsar-dotpulsar that referenced this issue Jul 25, 2021
@dionjansen
feat: apache#46 support nack delay and ack timeouts
e7df3a5 
* feat: apache#45 `Consumer` now supports `NegativeAcknowledge`
* add `AcknowledgementTimeout` to `ConsumerOptions`
* add `NegativeAcknowledgementRedeliveryDelay` to `ConsumerOptions`
* add `NegativeackedMessageState` to manage nacked messages
* add `UnackedMessageState` to manage unacked messages
* add `MessageTracker` to periodically check unacked and nacked messages, on a fixed polling timeout of 10ms
* add `AwaitingAck` to track both unacked and nacked messages
* add `InactiveMessageTracker` to reduce overhead when no `AcknowledgementTimeout` or `NegativeAcknowledgementRedeliveryDelay` is configured
* add `InactiveNegativeackedMessageState` to reduce overhead when no `NegativeAcknowledgementRedeliveryDelay` is configured
* add `InactiveUnackedMessageState` to reduce overhead when no `AcknowledgementTimeout` is configured
* update `ConsumerBuilder` to allow setting `AcknowledgementTimeout`
* update `ConsumerBuilder` to allow setting `NegativeAcknowledgementRedeliveryDelay`
* refactor `ConsumerChannel` to support `NegativeAcknowledge`
* refactor `AsyncQueue<T>` to implement missing interface `IAsyncQueue<T>`
* refactor `BatchHandler<TMessage>` to implement missing interface `IBatchHandler<TMessage>`
* add `AutoFixture` and `AutoFixture.AutoNSubstitute` dependencies to unit test project
* add missing `ConsumerBuilderTests` unit tests
* add missing `ConsumerChannelFactoryTests` unit tests
* add missing `ConsumerChannelTests` unit tests
* add missing `ConsumerTests` unit tests
* add IntegrationTests for consumer ack timout and nack delays
* skipped integration test `SinglePartition_WhenSendMessages_ThenGetMessagesFromSinglePartition` to avoid CI failures
* skipped integration test `RoundRobinPartition_WhenSendMessages_ThenGetMessagesFromPartitionsInOrder` to avoid CI failures

Closes: apache#46
Closes: apache#45
@wangshuyu
Copy link

In the main branch MSTER, there is still no NegativeAcknowledge function, and not confirming messages is a very core function. How can I use this function

@wangshuyu
Copy link

Hi @dionjansen It's not something I will be using myself, but I'm open for a discussion about how to implement it and of course to review and merge the PR, if you are up for creating one :-)

In the main branch MSTER, there is still no NegativeAcknowledge function, and not confirming messages is a very core function. How can I use this function
Do you have any better usage suggestions regarding the ability to not confirm messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #46 support nack delay and ack timeouts dionjansen/pulsar-dotpulsar
3 participants
@dionjansen @blankensteiner @wangshuyu