Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Dev] Revisit use of hadolint-docker #45200

Open
pitrou opened this issue Jan 8, 2025 · 3 comments
Open

[CI][Dev] Revisit use of hadolint-docker #45200

pitrou opened this issue Jan 8, 2025 · 3 comments
Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement

Comments

@pitrou
Copy link
Member

pitrou commented Jan 8, 2025 •
edited
Loading

Describe the enhancement requested

Applying hadolint to Dockerfiles does not seem to improve our code quality. It however forces us to litter the Dockerfiles with comments to disable some rules, reducing their readability.

For example, hadolint is not able to expand variables, so every use of FROM ${base} gets flagged as DL3006.

Component(s)

Continuous Integration, Developer Tools
@pitrou
Copy link
Member Author

pitrou commented Jan 8, 2025

cc @kou @assignUser

@pitrou
Copy link
Member Author

pitrou commented Jan 8, 2025

There has been an open issue for 6 years for the aforementioned DL3006 issue.

The last hadolint release was in 2022, more than 2 years ago. It seems almost unmaintained now.

@assignUser
Copy link
Member

Oh hadolint is written in haskell, no wonder maintenance is hard ^^

Maybe https://github.com/goodwithtech/dockle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pitrou @assignUser