Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ProblemList_openjdk**-openj9.txt to openj9 | ibm folder. #5835

Open
sophia-guo opened this issue Dec 23, 2024 · 4 comments
Open

Refactor ProblemList_openjdk**-openj9.txt to openj9 | ibm folder. #5835

sophia-guo opened this issue Dec 23, 2024 · 4 comments

Comments

@sophia-guo
Copy link
Contributor

sophia-guo commented Dec 23, 2024

Vendor specific ProblemLists (excludes/vendors/vendor/ProblemList_openjdk*.txt) is used for handling vendor specific features . Common temporary problemlists stays in openjdk/excludes/ProblemList_openjdk*.txt.

Currently openj9|IBM problemlists is an exception, which has a different name for problemlist. Most of the exclusions in problemlist is duplicated in openj9 problemlist. And when re-enable both files need to be updated.

Suggest to refactor those files. Move openj9 problemlist to openj9|ibm as a vendor folder. Renaming the "-openj9" problemlist as normal ones. Removing all duplicate exclusions in openj9 problemlist.

This can eliminate the redundancy, ease the maintenance, improve the consistency and make openj9 problemlist simple and clear to its own issues.

@sophia-guo
Copy link
Contributor Author

openj9 sdk has following properties
"-DJDK_IMPL=openj9" "-DJDK_VENDOR=eclipse"
"-DJDK_IMPL=openj9" "-DJDK_VENDOR=ibm"

@llxia
Copy link
Contributor

llxia commented Jan 14, 2025

Thanks for trying to optimize the workflow. It would be great if we could reduce the common work and reduce the duplication.

Currently, the exclusion workflow is the following:

When running OpenJDK tests against openj9/ibm, we do not use ProblemList for hotspot (ProblemList_openjdkXXX.txt) at all.

This issue suggests moving Openj9 ProblemList (ProblemList_openjdkXXX-openj9.txt) in aqa repo to vendor dir and using ProblemList for hotspot (ProblemList_openjdkXXX.txt) as the common one. While this could reduce the work for common excludes (i.e., issues with OpenJDK https://bugs.openjdk.org/), this also means any exclude in ProblemList_openjdkXXX.txt that is not common will affect openj9 runs (i.e, Adoptium infra specific excludes or Temurin specific excludes, etc), which may not be ideal.

In summary, I am all for simplifying and optimizing the workflow, but IMHO we need to have a real common ProblemList (i.e., common issues with OpenJDK only https://bugs.openjdk.org/). And we could also have a common ProblemList for common infra issues if needed. Any other infra or JVM-specific excludes should go to vendor excludes. (If we want to be sophisticated, we may want to have an infra ProblemList per site ).

cc @smlambert @pshipton @JasonFengJ9 for any comments and suggestions.

@sophia-guo
Copy link
Contributor Author

ProblemList_openjdkXXX.txt is used as common one, which currently listed issues tracked by JBS and issues tracked by aqa-tests. The issues tracked by aqa-tests with label 'JBS' need to be reported to JBS and move to JBS eventually. The issues tracked by aqa-tests without label 'JBS' should be moved to https://github.com/adoptium/aqa-tests/tree/master/openjdk/excludes/vendors/eclipse by default.

@sophia-guo
Copy link
Contributor Author

This can also be done for newer version (25+) first and then for older versions if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants