Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set correct log level depending on error #2059

Open
dborovcanin opened this issue Jan 21, 2024 · 2 comments · May be fixed by #2196
Open

Set correct log level depending on error #2059

dborovcanin opened this issue Jan 21, 2024 · 2 comments · May be fixed by #2196
Assignees
@dborovcanin
Labels
enhancement needs-comments
Milestone
0.15.0

Comments

@dborovcanin
Copy link
Collaborator

dborovcanin commented Jan 21, 2024 •
edited
Loading

Currently, all unsuccessful logs are Warn. In some cases, it makes sense to use Error, but it requires inspecting an error and possibly error handling refactoring.
@dborovcanin dborovcanin converted this from a draft issue Jan 21, 2024
@dborovcanin dborovcanin self-assigned this Jan 21, 2024
@dborovcanin dborovcanin added this to the S3 milestone Apr 17, 2024
@nyagamunene nyagamunene linked a pull request Apr 23, 2024 that will close this issue
Draft
@arvindh123 arvindh123 moved this from Todo to In Progress in SuperMQ Apr 29, 2024
@arvindh123 arvindh123 moved this from In Progress to 🧪 Review and testing in progress in SuperMQ Apr 29, 2024
@dborovcanin dborovcanin modified the milestones: S3, S4 Apr 30, 2024
@dborovcanin dborovcanin modified the milestones: S4, S5 May 15, 2024
@arvindh123 arvindh123 moved this from 🧪 Review and testing in progress to Todo in SuperMQ May 30, 2024
@nyagamunene nyagamunene moved this from Todo to In Progress in SuperMQ Jun 5, 2024
@dborovcanin dborovcanin modified the milestones: S5, 0.15.0 Jun 12, 2024
@dborovcanin
Copy link
Collaborator Author

@dborovcanin This is the priority since it can have a huge impact to other PRs and the rest of the codebase.

This was referenced Jun 23, 2024
Open
Closed
@dborovcanin
Copy link
Collaborator Author

Related to #1291.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dborovcanin dborovcanin

Labels
enhancement needs-comments
Projects
SuperMQ
Status: 🚧 In Progress
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

MG-2059 - Set correct log level depending on error nyagamunene/supermq
2 participants
@dborovcanin @nyagamunene