Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEI supply APY is coming through as 0 #1144

Open
drewcook opened this issue Sep 16, 2022 · 1 comment
Open

FEI supply APY is coming through as 0 #1144

drewcook opened this issue Sep 16, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@drewcook
Copy link
Contributor

drewcook commented Sep 16, 2022

Describe the bug

The supply APY for the FEI asset on Eth mainnet is not coming through from the API. This could either be an API issue or a UI issue. It's worth investigating which.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://app.aave.com/reserve-overview/?underlyingAsset=0x956f47f50a910163d8bf957cf5846d573e7f87ca&marketName=proto_mainnet
  2. Observe the 0% APY for supplies

Expected behavior
Should show accurate percentage rates.

@sakulstra
Copy link
Collaborator

sakulstra commented Sep 16, 2022

Some more issues with the rates api:

Only v2 markets supported (half a year after v3 was released)

Stable rate is almost always wrong (should always be analog to variable rate, but higher).
image
The issue is probably that stable rate on the subgraph is only updated when someone uses it (didn't check, but assume that's what is happening), so https://github.com/aave/aave-api/blob/master/src/services/RatesHistory.ts#L105 will always get the same value.
Should be rather easy to just calculate the stable rate based on the utilization at that point in time.

@drewcook drewcook added the bug Something isn't working label Sep 19, 2022
@drewcook drewcook reopened this Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants