resolveSelect doesn't work inside data store resolvers, select throws warnings

[danieliser]

Description

Have some custom data stores in a plugin, for some time now our fully TS data store package shows notices of

`select` control in `@wordpress/data-controls` is deprecated since version 5.7. Please use built-in `resolveSelect` control in `@wordpress/data` instead.

Ok so I spent a couple hours replacing everything, seems simple enough as select just passes through to resolveSelect.

• broken: https://github.com/PopupMaker/Popup-Maker/blob/a2608454520656210a722ffff8bd054d9516ca28/packages/core-data/src/call-to-actions/actions.ts#L133
• working: https://github.com/PopupMaker/Popup-Maker/blame/c064f5cf233fc8f01a0ddc34946473337183629c/packages/core-data/src/call-to-actions/actions.ts#L2

Its currently yield*, but I've tried normal yield as well, await simply doesn't seem to work within generators without lots of extra work wrapping every call with call( async () => {} )**

After swapping them out though, the generators stopped working for all resolvers.

I'm not sure what this deprecated notice is about, but it seems like a misleading notice here, clearly something else happening.

Side note, the typing for the resolveSelect is kinda terrible, why not have it simply return selector for given data store?

We have fully working type overloads for select, dispatch etc for our custom data stores, so I imagine it could be done in core in an interface pretty easily and ready to extend.

Step-by-step reproduction instructions

Consume resolveSelect within a generator for Redux data store resolver. It doesn't work from my testing, but using select which does work throws notices.

Screenshots, screen recording, code snippet

No response

Environment info

• Latest Gutenberg plugin, have dev version too.
• Latest WP core.

Please confirm that you have searched existing issues in the repo.

• Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

• Yes

Please confirm which theme type you used for testing.

• Block
• Classic
• Hybrid (e.g. classic with theme.json)
• Not sure

[Mamaduka]

@danieliser, check out the PR introducing deprecation for the @wordpress/data-controls package. It also lists a couple of migration PRs for core - #26509.

All block editor stores also switched from "generators" to "thunks" a while ago, which are much easier to work with, in my opinion. You can read more about this change here - https://developer.wordpress.org/block-editor/how-to-guides/thunks/.

[danieliser]

@Mamaduka Many thanks. I've tried to address this on multiple ocassions.

Will give those read and report back.